Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7746 inital changes for confirmation #7758

Closed
wants to merge 1 commit into from
+8 −1
Closed

7746 inital changes for confirmation #7758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Nethermind/Nethermind.Runner/Ethereum/Steps/StartRpc.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// SPDX-FileCopyrightText: 2022 Demerzel Solutions Limited
// SPDX-License-Identifier: LGPL-3.0-only

using System;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
Expand All @@ -11,6 +12,7 @@
using Nethermind.JsonRpc;
using Nethermind.JsonRpc.Modules;
using Nethermind.JsonRpc.WebSockets;
using Nethermind.KeyStore.Config;
using Nethermind.Logging;
using Nethermind.Runner.JsonRpc;
using Nethermind.Serialization.Json;
Expand All @@ -30,6 +32,11 @@ public StartRpc(INethermindApi api)
public async Task Execute(CancellationToken cancellationToken)
{
IJsonRpcConfig jsonRpcConfig = _api.Config<IJsonRpcConfig>();
IKeyStoreConfig keyStoreConfig = _api.Config<IKeyStoreConfig>();

// updating jwt-secret path based on data directory.
jsonRpcConfig.JwtSecretFile = String.Concat(keyStoreConfig.KeyStoreDirectory,"/jwt-secret");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change actually introduces another bug disrespecting the JsonRpc.JwtSecretFile setting. I think we should remove the default value of the IJsonRpcConfig.JwtSecretFile and check for null. If null, then apply this change.


ILogger logger = _api.LogManager.GetClassLogger();

if (jsonRpcConfig.Enabled)
Expand Down
2 changes: 1 addition & 1 deletion src/bench_precompiles
Open in desktop
Submodule bench_precompiles updated 3 files
+37 −0 vectors/ec_recover/current/ecRecover.json
+1,642 −0 vectors/point_evaluation/current/fail-pointEvaluation.json
+9 −0 vectors/point_evaluation/current/pointEvaluation.json