Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: standardized error responses for payload validation #7939

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: standardized error responses for payload validation #7939

wants to merge 1 commit into from
+41 −35

Conversation

merklefruit
Copy link

Fixes #7901

Changes

  • Added more descriptive payload validation error responses in engine API

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

Remarks

More context on this change can be found in #7901

@merklefruit merklefruit mentioned this pull request Dec 19, 2024
Merged
@merklefruit
Copy link
Author

Hi @MarekM25, can I help add context for a review? Would love to see this merged if possible

@LukaszRozmej
Copy link
Member

@kamilchodola It would be good to run engine and pyspec hive tests on this PR. But I cannot seem to run them on outside branches from actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@MarekM25 MarekM25 Awaiting requested review from MarekM25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add standardized error messages in engine API responses
2 participants
@merklefruit @LukaszRozmej