Fix search debounce #187
Draft
Fix search debounce #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubo
commented
Aug 15, 2024
| @@ -107,44 +107,49 @@ export default function AVSList() { | |||
|
|
|||
| const handlePageClick = useCallback( | |||
| page => { | |||
| setSearchParams({ page: page.toString() }); | |||
| searchParams.set('page', page.toString()); | |||
There was a problem hiding this comment.
Do we need to copy it before mutating?
Zishan-7
requested changes
Sep 13, 2024
|
@rubo does the same behaviour happen for AVS details operator table? I implemented the search functionality slightly differently there |
|
@vincenthongzy I checked; it works fine. Maybe we can apply that approach here as well to avoid issues with navigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed AVS search debounce not to make many requests in a row when search parameters changed. This has been caused by incorrect dependency configuration in
useEffect. Therefore,useEffectis now split into 2 different ones with different set of dependencies.The fix should be applied to other views as well.