-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add promoted operators #203
Conversation
b5d7c26
to
1738c21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7a0f8ff
to
7bcb29e
Compare
src/avs/AVSDetailsOperatorsTab.jsx
Outdated
promotedOperatorsRate: response.rate | ||
}); | ||
} catch (e) { | ||
//TODO: handle error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why no error handling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the promoted operators endpoint fails, we don't need to display error, so we just swallow it up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That TODO
confused me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll reword this comment
Two pages with slightly different information displayed:
/operators
/avs/:address/operators
Some edge cases to consider:
/avs/:address/operators
, it is ok to not show promoted operators if they are not currently securing the AVSBackend PR:
https://github.com/NethermindEth/restaking-dashboard-backend/pull/114