Add Custom onboarding pages #209
Conversation
src/onboarding/Login.jsx
Outdated
| const handleGoogleLogin = async () => { | ||
| await signIn.authenticateWithRedirect({ | ||
| strategy: 'oauth_google', | ||
| redirectUrl: |
There was a problem hiding this comment.
Need to update the redirect URL with the Nethermind account redirect URL (need to setup in clerk dashboard)
| {...register('email', { | ||
| required: 'Email is required', | ||
| pattern: { | ||
| value: RegExp(/^[^\s@]+@[^\s@]+\.[^\s@]+$/), |
There was a problem hiding this comment.
Hmm emails are notoriously hard to create a regex for. This is definitely too simple, but I guess we don't really need to do validation so strictly. If the user never receive an OTP through the email that means they have made a mistake on their end
There was a problem hiding this comment.
context for the curios https://stackoverflow.com/a/201378
| @@ -62,7 +72,8 @@ export default { | |||
| outline: '#293041', | |||
| primary: '#cad7f9', | |||
| secondary: '#ffcc80', | |||
| success: '#7ccb69' | |||
| success: '#7ccb69', | |||
| danger: '#d24646' | |||
There was a problem hiding this comment.
nit: why not re-use our error variants?
There was a problem hiding this comment.
Carlos asked to use this color 😬
There was a problem hiding this comment.
Did you let him know there is already something similar with our error variants?
|
As discussed with Clem, hiding google login till oAuth is setup. |
react-hook-formis used for form validation.