[EIP-7706] State transition gas handling #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR tackling #12 (EIP-7706)
New transaction type
As per EIP-7706, this PR adds a new transaction type, called
tx_vector_fee
, named that way to immediately suggest that our fees are now multi-dimensional.Furthermore, I've updated the core
transaction
type as well as the "old" transaction types (i.e.,tx_dyamic_fee
,tx_legacy
, etc.) to align them with this EIP.State transition gas changes
The focus of the PR is "gas handling" changes per EIP-7706 during state transition.
By "gas handling" I mean:
Changes to
state_transition
follow this "template," exemplified on the preCheckGasThis is to say, when, e.g., doing "gas pre-checks," I have:
preCheckGas
preCheckGasEIP7706
) or the "old code," now moved to the functionpreCheckGasEip4484
As mentioned above, other changes like buying gas or refunding gas follow the same pattern.
Code in the
*EIP4484
functions is unchanged from the upstreamWhat's missing
Well everything not mentioned above 😅
But most importantly, block changes required by EIP-7706 are not in this PR, but they are planned for the next one :)