Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!refactor: update "sedge-data" default directory #468

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

khalifaa55
Copy link
Contributor

Changes:

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

@khalifaa55 khalifaa55 self-assigned this Oct 29, 2024
@khalifaa55 khalifaa55 mentioned this pull request Oct 29, 2024
12 tasks
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 24.65%. Comparing base (6d8c249) to head (766754a).

Files with missing lines Patch % Lines
configs/messages.go 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #468      +/-   ##
===========================================
+ Coverage    24.61%   24.65%   +0.03%     
===========================================
  Files          119      119              
  Lines        22000    22006       +6     
===========================================
+ Hits          5416     5425       +9     
+ Misses       16058    16055       -3     
  Partials       526      526              
Flag Coverage Δ
unittests 24.65% <90.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AntiD2ta AntiD2ta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Although we should leave it open until we are ready to make a major version change

@AntiD2ta AntiD2ta changed the title Refac: Update "sedge-data" default directory !refactor: update "sedge-data" default directory Oct 31, 2024
@AntiD2ta AntiD2ta added the 2.0 label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants