Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mev boost issue on Lodestar #485

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Fix mev boost issue on Lodestar #485

merged 2 commits into from
Dec 4, 2024

Conversation

stdevMac
Copy link
Member

Changes:

  • Add missing = sign on lodestar when setting a builder

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

Comments about testing , should you have some (optional)

Further comments (optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.73%. Comparing base (6e485d7) to head (1413015).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #485      +/-   ##
===========================================
- Coverage    24.75%   24.73%   -0.03%     
===========================================
  Files          120      120              
  Lines        22299    22299              
===========================================
- Hits          5521     5515       -6     
- Misses       16235    16239       +4     
- Partials       543      545       +2     
Flag Coverage Δ
unittests 24.73% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stdevMac stdevMac merged commit a0d5bbb into develop Dec 4, 2024
11 checks passed
@stdevMac stdevMac deleted the fix/mev-boost branch December 4, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants