PR comment fixes

NethermindEth · Oct 24, 2024 · ca49bff · ca49bff
1 parent b093f93
commit ca49bff
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/mocks/mock_rpc_provider.go b/mocks/mock_rpc_provider.go
diff --git a/rpc/provider.go b/rpc/provider.go
@@ -60,7 +60,7 @@ type RpcProvider interface {
 	EstimateMessageFee(ctx context.Context, msg MsgFromL1, blockID BlockID) (*FeeEstimation, error)
 	Events(ctx context.Context, input EventsInput) (*EventChunk, error)
 	GetTransactionStatus(ctx context.Context, transactionHash *felt.Felt) (*TxnStatusResp, error)
-	GetMessagesStatus(ctx context.Context, transactionHash *felt.Felt) ([]MessageStatusResp, error)
+	GetMessagesStatus(ctx context.Context, transactionHash NumAsHex) ([]MessageStatusResp, error)
 	Nonce(ctx context.Context, blockID BlockID, contractAddress *felt.Felt) (*felt.Felt, error)
 	SimulateTransactions(ctx context.Context, blockID BlockID, txns []BroadcastTxn, simulationFlags []SimulationFlag) ([]SimulatedTransaction, error)
 	StateUpdate(ctx context.Context, blockID BlockID) (*StateUpdateOutput, error)

diff --git a/rpc/transaction.go b/rpc/transaction.go
@@ -72,15 +72,15 @@ func (provider *Provider) GetTransactionStatus(ctx context.Context, transactionH
 	return &receipt, nil
 }
 
-// Given an l1 tx hash, returns the associated l1_handler tx hashes and statuses for all L1 -> L2 messages sent by the l1 transaction, ordered by the l1 tx sending order
+// Given an L1 tx hash, returns the associated l1_handler tx hashes and statuses for all L1 -> L2 messages sent by the l1 transaction, ordered by the L1 tx sending order
 //
 // Parameters:
 // - ctx: the context.Context object for cancellation and timeouts.
-// - transactionHash: The hash of the L1 transaction that sent L1->L2 messages as a felt
+// - transactionHash: The hash of the L1 transaction that sent L1->L2 messages
 // Returns:
-// - [] MessageStatusResp: An array containing the status of the messages sent by the l1 transaction
+// - [] MessageStatusResp: An array containing the status of the messages sent by the L1 transaction
 // - error, if one arose.
-func (provider *Provider) GetMessagesStatus(ctx context.Context, transactionHash *felt.Felt) ([]MessageStatusResp, error) {
+func (provider *Provider) GetMessagesStatus(ctx context.Context, transactionHash NumAsHex) ([]MessageStatusResp, error) {
 	var response []MessageStatusResp
 	err := do(ctx, provider.c, "starknet_getMessagesStatus", &response, transactionHash)
 	if err != nil {

diff --git a/rpc/types_transaction_receipt.go b/rpc/types_transaction_receipt.go
@@ -29,7 +29,7 @@ type MsgFromL1 struct {
 }
 
 type MessageStatusResp struct {
-	// The hash of a Starknet transaction
+	// The hash of a L1 handler transaction
 	TransactionHash *felt.Felt `json:"transaction_hash"`
 	// The finality status of the transaction, including the case the txn is still in the mempool or failed validation during the block construction phase
 	FinalityStatus TxnStatus `json:"finality_status"`