Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes before 7.1 release #617

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Conversation

thiagodeev
Copy link
Collaborator

@thiagodeev thiagodeev commented Aug 23, 2024

  • Fixes BlockWithTxHashes and BlockWithTxs methods not returning all values of pending blocks;
  • Improves the tests of these methods and creates a mock scenario for the BlockWithTxs method;
  • Remotions:
    • Unused parameters from mock_test.go, thus removing the warnings;
    • 'TestGetBlock' at 'provider_test.go' as the 'TestBlockWithTxHashes' already tests the BlockWithTxHashes method;
    • 'TestBlockWithTxsAndInvokeTXNV0', 'TestBlockWithTxsAndInvokeTXNV1', 'TestBlockWithTxsAndInvokeTXNV3', and 'TestBlockWithTxsAndDeployOrDeclare'. They were unified into the 'TestBlockWithTxs' test;
    • 'sepoliaBlockTxs64159.json' file. Replaced by another block with more variety of transaction types.

@thiagodeev thiagodeev marked this pull request as draft August 23, 2024 03:49
@thiagodeev thiagodeev force-pushed the thiagodeev/fixes-before-7_1-release branch from 5cf84ad to b12cc3b Compare August 23, 2024 04:17
@thiagodeev thiagodeev force-pushed the thiagodeev/fixes-before-7_1-release branch from b12cc3b to 6c95f99 Compare August 23, 2024 04:20
@thiagodeev thiagodeev marked this pull request as ready for review August 23, 2024 21:31
@thiagodeev thiagodeev merged commit e7ef219 into main Aug 23, 2024
6 checks passed
@thiagodeev thiagodeev deleted the thiagodeev/fixes-before-7_1-release branch August 23, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants