starknet_getCompiledCasm #642
Conversation
| type CasmCompiledContractClass struct { | ||
| EntryPointsByType CasmEntryPointsByType `json:"entry_points_by_type"` | ||
| ByteCode []*felt.Felt `json:"bytecode"` | ||
| Prime []*felt.Felt `json:"prime"` |
There was a problem hiding this comment.
Why not NumAsHex for prime?
There was a problem hiding this comment.
Nice catch, thanks!
| ByteCode []*felt.Felt `json:"bytecode"` | ||
| Prime []*felt.Felt `json:"prime"` | ||
| CompilerVersion string `json:"compiler_version"` | ||
| Hints Hints `json:"hints"` |
There was a problem hiding this comment.
I think this should be [2]Hints
There was a problem hiding this comment.
I did that because hints is a tuple of [intenger, []hint] and Golang doesn't allow an array of multiple types. So I created a struct having these two fields and two helper methods for getting the values: the Values() that returns both values the way Golang usually does (int, []Hint) and the Tuple() that returns an [2]any array in case someone needs it in this format
| @@ -16,3 +19,18 @@ func UnwrapJSON(data map[string]interface{}, tag string) (map[string]interface{} | |||
| } | |||
| return data, nil | |||
| } | |||
|
|
|||
| func GetTypedFieldFromJSON[T any](data map[string]interface{}, tag string) (T, error) { | |||
There was a problem hiding this comment.
I was using it in previous commits but not now, I'll remove it then
| func (hints *Hints) Values() (int, []Hint) { | ||
| return hints.Int, hints.HintArr | ||
| } | ||
|
|
||
| func (hints *Hints) Tuple() [2]any { | ||
| return [2]any{hints.Int, hints.HintArr} | ||
| } |
There was a problem hiding this comment.
What are these functions for?
There was a problem hiding this comment.
Answered here
#623
This PR aims to implement some RPC v0.8.0 updates to starknet.go. The ones addressed by this PR are:
Methods
starknet_getCompiledCasm
Components
CASM_COMPILED_CONTRACT_CLASS
CASM_ENTRY_POINT
CellRef
Deref
DoubleDeref
Immediate
BinOp
ResOperand
HINT
DEPRECATED_HINT
CORE_HINT
STARKNET_HINT
Errors
COMPILATION_ERROR
Note: As the RPC v0.8.0 has not yet been released, we can't fully test these changes as the nodes haven't implemented them yet. They will be updated before merging into main
Also, there's the creation of a new utility to get a typed field from a map representing a JSON