-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be better at documenting #5
Comments
This documents most declarations in the init functions and also adds documentation for the functions themselves. The storage bingo:main was renamed to bingo:items Setup lobby is no longer executed positioned 0 0 0, but instead the commands used in that function are executed on global coordinates. Work towards #5
This documents most declarations in the init functions and also adds documentation for the functions themselves. The storage bingo:main was renamed to bingo:items Setup lobby is no longer executed positioned 0 0 0, but instead the commands used in that function are executed on global coordinates. Work towards #5
This documents the tick and set_player_id function (work towards #5). Both functions are moved to the tick subfolder now.
This adds documentation to all util ffunctions. Work towards #5 Additionally, some names in match_uuid changed.
Adds documentation to prefrences. Work towards #5
This documents the card_frames sub folder. Furthermore, temporary storages are renamed to follow the new scheme (Work towards #5) and the tag bingo.unmark has the inverse functionality and is now called bingo.toggle_on.
This documents card display functions (Work towards #5) score_holder name $y follows new rules for temporary score holder names and is now called $card_display/display_card.y.
This documents the function responsible for setting signs in the lobby. Work towards #5
This moves internal scores used by the timer from 91.timer.main to 91.timer.intern. The sole constant (value 60) was also moved from 91.timer.const to the new objective, and the const objective was removed. All internal score holders are also properly documented now (Work towards #5)
Is lacking bingo/data/bingo/functions/game/start/set_spawn.mcfunction Lines 1 to 6 in c8e309b
from here (
|
Is
|
# items: (Compund List) (readonly) List of all items this category has. Entries | |
# have the same structure as in the items array. Will be created | |
# automatically, after #bingo:post_register_items ran. |
bingo:registries
- mentions both:bingo/data/bingo/functions/init/init.mcfunction
Lines 67 to 69 in d8fc361
# To execute an action before the registries are processed but after all active | |
# extension packs have registered everything, add a function to the function tag | |
# #bingo:post_registration |
bingo/data/bingo/functions/init/init.mcfunction
Lines 82 to 84 in d8fc361
# In order to modify existing items, either added by the default bingo datapack, | |
# or added by another extension pack, please use a function registered to the | |
# function tag #bingo:post_register_items |
#bingo:post_register_items
#bingo:post_registration
declaration:bingo/data/bingo/functions/init/init.mcfunction
Lines 1119 to 1128 in d8fc361
#> | |
# Function tag for doing actions after the item registration, but before the | |
# items are duplicated into the categories array. | |
# | |
# You may use this function tag for modifing existing items from the default | |
# bingo item pool or from other extensio packs. | |
# | |
# @api | |
#declare tag/function bingo:post_registration | |
function #bingo:post_registration |
Maybe add info that
|
# This storage is used to keep track of all items that are available in | |
# Minecraft: Bingo. |
bingo/data/bingo/functions/init/init.mcfunction
Lines 1131 to 1146 in d8fc361
#region initialize items | |
#> | |
# @within function bingo:init/* | |
#declare storage tmp.bingo:init | |
# initialize items | |
data modify storage tmp.bingo:init items set from storage bingo:registries items | |
data modify storage bingo:items categories set from storage bingo:registries categories | |
data remove storage bingo:items items | |
function bingo:init/initialize_items | |
execute unless data storage bingo:items activeTags run data modify storage bingo:items activeTags set value ["bingo:default"] | |
# Schedule to avoid maxCommandChainLength being hit (setting it in init doesn't work the first time) | |
schedule function bingo:util/apply_active_item_tags 1t | |
#endregion |
Add more info about
|
#> | |
# Whether strict mode is turned on | |
# | |
# @internal | |
#declare score_holder $strict_mode | |
scoreboard players add $strict_mode bingo.settings 0 |
Maybe encapsulate
|
#> | |
# Whether the card needs to be updated | |
# | |
# @internal | |
#declare score_holder $update_card | |
#> | |
# @public | |
#declare score_holder -2 | |
scoreboard players set -2 bingo.const -2 | |
#> | |
# @public | |
#declare score_holder -1 | |
scoreboard players set -1 bingo.const -1 |
Add declaration for
|
#region run registries | |
data remove storage bingo:registries categories | |
data remove storage bingo:registries items | |
data remove storage bingo:registries structures | |
data remove storage bingo:registries hud_components | |
data remove storage bingo:registries preferences | |
function #bingo:fill_registries |
Explain registration of own items (or delete line
|
#> bingo:init/fill_registries | |
# | |
# Registers everything in vanilla bingo. | |
# | |
# To register your own ite |
- misspellings - missing letters - improved some descriptions NeunEinser#5
Only tags that are not otherwise declared (through a file) are declared with |
I think |
I think it's good enough now. No need to keep track of this issue anymore. |
There is no documentation.
git gud
The text was updated successfully, but these errors were encountered: