Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scan): add template to scan create #465

Merged
merged 7 commits into from
Oct 11, 2023
Merged

feat(scan): add template to scan create #465

merged 7 commits into from
Oct 11, 2023

Conversation

brightAMasiuk
Copy link
Contributor

closes #464

@brightAMasiuk brightAMasiuk added the Type: enhancement New feature or request. label Oct 4, 2023
@brightAMasiuk brightAMasiuk self-assigned this Oct 4, 2023
@brightAMasiuk brightAMasiuk marked this pull request as draft October 4, 2023 07:25
@derevnjuk derevnjuk force-pushed the master branch 2 times, most recently from 0fc353b to 19f53a6 Compare October 4, 2023 07:43
@brightAMasiuk brightAMasiuk force-pushed the feat-#464/add_teplate_id_to_scan branch 2 times, most recently from bf5b5af to af0436c Compare October 4, 2023 17:45
@brightAMasiuk brightAMasiuk force-pushed the feat-#464/add_teplate_id_to_scan branch from af0436c to 5f27046 Compare October 4, 2023 17:47
@brightAMasiuk brightAMasiuk requested a review from BMNTeam October 4, 2023 17:47
@brightAMasiuk brightAMasiuk marked this pull request as ready for review October 4, 2023 17:47
denis-maiorov-brightsec
denis-maiorov-brightsec requested changes Oct 6, 2023
View reviewed changes
src/Commands/RetestScan.ts Outdated Show resolved Hide resolved
src/Scan/RestScans.spec.ts Outdated Show resolved Hide resolved
src/Scan/RestScans.spec.ts Outdated Show resolved Hide resolved
@BMNTeam BMNTeam removed their request for review October 11, 2023 07:11
BMNTeam and others added 2 commits October 11, 2023 10:12
@BMNTeam @denis-maiorov-brightsec
Update src/Scan/RestScans.spec.ts
1b60ce6 
Co-authored-by: denis-maiorov-brightsec <[email protected]>
@BMNTeam @denis-maiorov-brightsec
Update src/Scan/RestScans.spec.ts
d54cf49 
Co-authored-by: denis-maiorov-brightsec <[email protected]>
@BMNTeam BMNTeam changed the base branch from master to alpha October 11, 2023 08:05
@BMNTeam BMNTeam changed the title feat(scan): add template to scan create/retest feat(scan): add template to scan create Oct 11, 2023
@BMNTeam BMNTeam assigned BMNTeam and unassigned brightAMasiuk Oct 11, 2023
@BMNTeam BMNTeam enabled auto-merge (squash) October 11, 2023 09:56
@BMNTeam BMNTeam changed the base branch from alpha to next October 11, 2023 11:37
denis-maiorov-brightsec
denis-maiorov-brightsec approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@denis-maiorov-brightsec denis-maiorov-brightsec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@BMNTeam BMNTeam merged commit c9724d2 into next Oct 11, 2023
4 checks passed
@BMNTeam BMNTeam deleted the feat-#464/add_teplate_id_to_scan branch October 11, 2023 11:51
@BMNTeam BMNTeam mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BMNTeam BMNTeam BMNTeam left review comments

@denis-maiorov-brightsec denis-maiorov-brightsec denis-maiorov-brightsec approved these changes

Assignees

@BMNTeam BMNTeam

Labels
Type: enhancement New feature or request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add --templateId parameter when create scan
3 participants
@brightAMasiuk @BMNTeam @denis-maiorov-brightsec