Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): write to stderr for errors and warnings #611

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Conversation

maksadbek
Copy link
Collaborator

@maksadbek maksadbek commented Nov 14, 2024

BREAKING CHANGE: Warning logs are now written to stderr instead of stdout.

@maksadbek maksadbek added Type: bug Something isn't working. javascript Pull requests that update Javascript code labels Nov 14, 2024
@maksadbek maksadbek self-assigned this Nov 14, 2024
src/Utils/Logger.ts Outdated Show resolved Hide resolved
Co-authored-by: Artem Derevnjuk <[email protected]>
@maksadbek maksadbek added Type: enhancement New feature or request. and removed Type: bug Something isn't working. labels Nov 14, 2024
@maksadbek maksadbek changed the title fix(logger): write to stderr for errors and warnings feat(logger): write to stderr for errors and warnings Nov 14, 2024
@derevnjuk
Copy link
Member

@maksadbek you should describe the breaking changes as follows:

Breaking Changes After the merge, a new major version (v13) will be released.

@orubin
Copy link
Contributor

orubin commented Nov 14, 2024

@maksadbek you should describe the breaking changes as follows:

Breaking Changes After the merge, a new major version (v13) will be released.

@adirdidi @bararchy FYI, the logging fix will trigger v13 release - breaking change.

@maksadbek maksadbek requested a review from derevnjuk November 14, 2024 15:56
@derevnjuk
Copy link
Member

@orubin not immediately ofc, we will release the v13 release candidate (i.e., v13.0.0-next.1) first. We can postpone the final release of v13 and maintain both v12.x and the v13.x.x-next.x for a while and you can plan other breaking changes and migration util this moment.

@maksadbek in that case, you need to keep working in next branch and use cherry-picks to port changes from next to main when needed instead of merge as before.

@adirdidi
Copy link

Will update you about v13 release, we may add one more feature to it (discovery).

@derevnjuk derevnjuk changed the title feat(logger): write to stderr for errors and warnings feat(*): write to stderr for errors and warnings Nov 14, 2024
@maksadbek maksadbek merged commit dca5312 into next Nov 14, 2024
6 checks passed
@maksadbek maksadbek deleted the warn-logs-to-stderr branch November 14, 2024 20:14
@derevnjuk derevnjuk restored the warn-logs-to-stderr branch November 15, 2024 09:41
derevnjuk added a commit that referenced this pull request Nov 15, 2024
BREAKING CHANGE: Warning logs are now written to stderr instead of
stdout.

Supersedes: #611
Co-authored-by: Maksadbek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code Type: enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants