Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't spawn ingress if repeater is used #340

Merged
merged 1 commit into from
May 30, 2024
Merged

Don't spawn ingress if repeater is used #340

merged 1 commit into from
May 30, 2024

Conversation

rielas
Copy link
Contributor

@rielas rielas commented May 29, 2024

denanmusinovic
denanmusinovic previously approved these changes May 29, 2024
Copy link
Contributor

@denanmusinovic denanmusinovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rielas It's working properly.

@@ -200,8 +200,7 @@ spec:
- name: CLUSTER
value: "{{ .Values.cluster }}"
- name: TIMEOUT
value: "{{ .Values.timeout | default "30000" }}"
restartPolicy: Always
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i had to remove this line, and put it on bottom bellow sniffer container. This line is not container specific, it goes for all containers.

@denanmusinovic denanmusinovic force-pushed the IR-498 branch 2 times, most recently from 577e639 to cc2cfb6 Compare May 30, 2024 11:38
@rielas rielas merged commit 68cb46c into unstable May 30, 2024
2 checks passed
@rielas rielas deleted the IR-498 branch May 30, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants