Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downgrade libxmljs to 0.10.7 #344

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

pmstss
Copy link
Contributor

@pmstss pmstss commented Jun 14, 2024

relates-to #341

@pmstss pmstss added the dependencies Pull requests that update a dependency file label Jun 14, 2024
@pmstss pmstss self-assigned this Jun 14, 2024
@pmstss
Copy link
Contributor Author

pmstss commented Jun 14, 2024

for libxmljs v0.19.10 precompiled binaries for currently used node v14 (ABI v83) are available, but cause a silent exit with status 0 for nodejs process on attempt to parse XML (e.g. on POST /api/metadata route).
for libxmljs v0.19.7 ABI v83 binaries are not available, and thus they are built from scratch - and this way they do not cause an issues during XML parsing
drawback of this is that pretty heavy python3 py3-pip make g++ are still required in docker

@pmstss pmstss merged commit 649334a into unstable Jun 14, 2024
3 checks passed
@pmstss pmstss deleted the fix/downgrade_libxmljs_to_0.10.7 branch June 14, 2024 15:00
rielas pushed a commit that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant