Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: unify API for plugin installation #401

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

derevnjuk
Copy link
Member

No description provided.

@derevnjuk derevnjuk added Type: enhancement New feature or request. Type: technical debt Changes that remove or significantly update old unused code and/or dependencies. labels Jan 24, 2024
@derevnjuk derevnjuk self-assigned this Jan 24, 2024
Copy link

cypress bot commented Jan 24, 2024

Passing run #13 ↗︎

0 30 5 0 Flakiness 0

Details:

Merge b33516b into 41a41f3...
Project: cypress-har-generator Commit: d0b059bd48 ℹ️
Status: Passed Duration: 02:01 💡
Started: Jan 24, 2024 11:16 AM Ended: Jan 24, 2024 11:18 AM

Review all test suite changes for PR #401 ↗︎

@derevnjuk derevnjuk force-pushed the feat/unify-API-for-plugin-installation branch from 28740fa to b33516b Compare January 24, 2024 11:15
@@ -125,20 +129,20 @@ describe('my tests', () => {

By default, the plugin will save the generated HAR file to the root of your project with a file name that includes the current spec's name (e.g. `{specName}.har`).

You can also specify a different destination folder for the generated HAR file by setting the `CYPRESS_HARS_FOLDERS` environment variable or the `hars_folders` field in the `env` object in your Cypress config file:
You can also specify a different destination folder for the generated HAR file by setting the `CYPRESS_HARS_FOLDER` environment variable or the `hars_folder` field in the `env` object in your Cypress config file:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest using a singular form here:

Suggested change
You can also specify a different destination folder for the generated HAR file by setting the `CYPRESS_HARS_FOLDER` environment variable or the `hars_folder` field in the `env` object in your Cypress config file:
You can also specify a different destination folder for the generated HAR file by setting the `CYPRESS_HAR_FOLDER` environment variable or the `har_folder` field in the `env` object in your Cypress config file:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request. Type: technical debt Changes that remove or significantly update old unused code and/or dependencies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants