-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TraceImageViewer, plus other small updates #177
Open
grahamfindlay
wants to merge
13
commits into
NeuralEnsemble:master
Choose a base branch
from
CSC-UW:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,675
−1,701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce, and define where needed.
Hi @samuelgarcia, what's the status on this? Can we merge or is there an alternative? |
@samuelgarcia just bumping this thread since it would be nice to have this feature merged! |
Oups. Thank you for the reminder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a prototype TraceImageViewer to display current source density (or any kind of signal vs time traces)
Example:
This is a very quick-and-simple minimal implementation, so there are a few known issues:
When the viewer is first opened, and the window displays a time range that extends beyond the edge of the data (e.g. data start at
0
, but window is(-2, +8)
),setImage
fills the whole window, so that the TraceImage is misaliged to traces. Example:The color limits are set based on the local image currently being displayed, not on the full data. This means that the RGB value on one page may not map to the same absolute CSD value on another page. Personally, I actually like it this way, but someone will be surprised by this behavior. Example (there is a 100ms scroll between these two images):
I naively added the ability to change multiplicative gain by scrolling the mousewheel, like in the TraceView, but because of issue 2 above, you can't actually see the effect, so I probably ought to just remove that logic to avoid confusion 🤦
Also made a few other small changes:
sample_rate
property onBaseAnalogSignalSource
, and implemented the property on necessary subclasses.matplotlib.cm.get_cmap(name, N)
pattern withmatplotlib.colormaps.get_cmap(name).resampled(N)