handle pagination - needed for Stieger2021 ds #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Samuel-Boehm, Thank you so much for your PR! We are super happy to receive this one. The issue in the CI is not related to your PR. I will fix in another PR, I am sorry for this unrelated issue. I come back in few hours. |
Samuel-Boehm
force-pushed
the
develop
branch
from
d28fd40 to
a71aaa8
Compare
|
Sorry If I made mistakes here! I am currently working on an implementation of the original BEETL dataset for MOABB and was on the way of finishing it. However, I didn't want it to end up here in the branch. I am kind of new to git and contributing to projects. I will write a new merge request for the BEETL set soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with the Stieger2021 dataset, I encountered an issue where only the first subject's data was being downloaded. The problem I found was
fs_get_file_listfunctionwasn't properly handling the Figshare API's pagination. With this implementation, the function now retrieves all files across every page of results, ensuring complete data collection for all subjects in the dataset.