Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final testing #325

Merged
merged 12 commits into from
Jan 25, 2024
Merged

Final testing #325

merged 12 commits into from
Jan 25, 2024

Conversation

anandpathak31
Copy link
Contributor

No description provided.

@helmutstrey
Copy link
Contributor

helmutstrey commented Jan 18, 2024

@harisorgn I just looked at your function get_weights. I noticed that it gets all the weights irrespective of the direction even though you specify blox_in, blox_out. Should you not make sure that that you only consider connection that go out->in which would mean that the position of name_out is left of name_in?

Maybe add condition: (findfirst(name_out,n)[1] < findfirst(name_in,n)[1])

@harisorgn
Copy link
Member

Should you not make sure that that you only consider connection that go out->in which would mean that the position of name_out is left of name_in?

Yep, fixed it another way, but basically it's now directional. Thanks!

@helmutstrey helmutstrey merged commit f37fe60 into master Jan 25, 2024
3 checks passed
@helmutstrey helmutstrey deleted the final_testing branch January 25, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants