WIP: rebase sDCM code for GUI integration #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. These functions replace the former spectralVI and variationalbayes and are substantially more concise. I also removed idx_A and the matrix V which formerly mapped from the whole parameter space to the subspace whose variances were not 0. In this new implementation we define parameters as not tunable rather than setting their variance to 0 if we don't want to optimize them. I also removed C, which is unsatisfyingly implemented in SPM12 anyways and needs to be properly implemented here in the future
…nd epsilon_theta were not stored from one loop iteration to the next and the reset if an iteration resulted in a deterioration of free energy was not implemented correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Tests will fail, we now deviate from SPM12 implementation. I removed its idiosyncracies like the weight parameter C for external imputs and the dimensionality reduction matrix V.
Need to rebase the code using the new functions setup_sDCM and run_sDCM_iteration! which are designed to be used with the GUI.