Cleanup and debug NMM #348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete old IF, LIF, QIF blox and associated helper functions and tests. Also remove `synaptic_network.jl` as it is fully replaced by `BloxConnector`
This was referenced Apr 9, 2024
Include citations and docstring formatting. Still finishing up QIF and Izhikevich
Synaptic conductances for these need to be scaled appropriately!
Also cleanup
|
Single block failures were all addressed with #342, so closing this PR as it's redundant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not to be merged yet! Opening to work on new tests for the single block issue.
Also includes cleanup for the old neuron blocks to be removed.