Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all plot recipes args consistent #453

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Make all plot recipes args consistent #453

merged 5 commits into from
Oct 11, 2024

Conversation

gabrevaya
Copy link
Contributor

All plot recipes now include at least the following keyword arguments: xlabel, ylabel, and title, which can be set as follows:

plotrecipe(blox, sol, xlabel = "my xlabel", ylabel = "my ylabel", title = "my title")

Additionally, all plot recipes come with default xlabel and ylabel values, but no default title. Any other Makie axis configuration not included in the plot recipe can be set using the regular syntax:

plotrecipe(blox, sol,
           xlabel = "my xlabel", ylabel = "my ylabel", title = "my title", 
           axis = (kwarg1 = ..., kwarg2 = ...))

I also removed the tolerance settings when solving the SDE problems in the basal ganglia tutorial. I had added them when I was aiming to reduce memory consumption, but the difference compared to the default settings was minimal (the main factor was the time span). Removing them simplifies the solution process, avoiding the need to mention the tolerances.

@harisorgn
Copy link
Member

Good to merge?

@gabrevaya
Copy link
Contributor Author

gabrevaya commented Oct 11, 2024 via email

@gabrevaya gabrevaya merged commit 868f01c into master Oct 11, 2024
6 checks passed
@gabrevaya gabrevaya deleted the plot_recipes_args branch October 11, 2024 14:06
@MasonProtter
Copy link
Contributor

@gabrevaya in the future please use the "Squash and merge" button when you merge PRs

@gabrevaya
Copy link
Contributor Author

@MasonProtter Yes, I apologize. I rushed to merge it before Helmut made the new release and forgot to squash it. I'll make sure to squash and merge future PRs. Thanks for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants