Improve type stability of reinforcement learning #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
david-hofmann
pushed a commit
that referenced
this pull request
Nov 11, 2024
* import Symbolics.variable
* add concrete types to learning rule fields
* add function to narrow Dict type
* narrow `learning_rules` type
* use a `Union{Nothing, Num}` instead of `Num` so that `maybe_set_state_*` works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves type stability and therefore RAM usage of
run_experiment!, mainly on the learning rule structs.Thanks @MasonProtter for the tips, feel free to review.