Move the with_stack
hack inside of the DCM code
#526
+26
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should resolve the issues of running out of stack space during the DCM trials without needing to put the
with_stack
stuff in the IAP notebooks. If my idea for switching to Enzyme for the jacobian works, then we won't need this, but I'll put it up for now just in case.Before merging, I need someone with 8 or less GB of RAM to check out this branch and tell me if this runs without errors: