Make neural mass housekeeping PR non-breaking #532
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR that is targeting #530, rather than a commit to that branch because I want to see what people think of this. This is an idea I had to make that PR non-breaking.
Basically, instead of having two separate types for noisy versus non-noisy, this PR puts them together into one type, but they differ by a type parameter, e.g.
I also changed the keyword argument back to
include_noise
rather thannoise
, since that is what current Neuroblox master uses.Any thoughts or feelings on this approach?