Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve readability of WC eqs in Getting started #9

Merged
merged 2 commits into from
Aug 5, 2024
Merged

improve readability of WC eqs in Getting started #9

merged 2 commits into from
Aug 5, 2024

Conversation

gabrevaya
Copy link
Contributor

Following #8

Should we also add descriptions of what the different terms in the eqs mean or do you prefer to keep it as concise as possible?

@gabrevaya gabrevaya requested a review from harisorgn August 2, 2024 14:34
Copy link
Member

@harisorgn harisorgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @gabrevaya for the clarifications. Later we should reassess whether we should do create_adjacenty_edges! here, as we have add_edge! as the alternative way of making a graph (although this API will change a bit, so let's keep it for later). We could maybe show both ways.

@harisorgn harisorgn merged commit 0142d91 into Neuroblox:main Aug 5, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants