Merge branch 'main' into VideoInterface

NeurodataWithoutBorders · Dec 29, 2023 · b2f9e83 · b2f9e83
2 parents f617858 + 86d0ffb
commit b2f9e83
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 11 deletions.
diff --git a/.github/workflows/chromatic.yml b/.github/workflows/chromatic.yml
@@ -1,9 +1,13 @@
-name: "Chromatic Publish"
+name: Chromatic
 
-on: workflow_dispatch
+on:
+  workflow_dispatch:
+  pull_request_review:
+    types: [submitted]
 
 jobs:
   test:
+    if: github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request_review' && github.event.review.state == 'approved')
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v1

diff --git a/guideGlobalMetadata.json b/guideGlobalMetadata.json
@@ -41,6 +41,7 @@
         "SpikeGLXConverterPipe",
         "BrukerTiffSinglePlaneConverter",
         "BrukerTiffMultiPlaneConverter",
-        "MiniscopeConverter"
+        "MiniscopeConverter",
+        "CellExplorerRecordingInterface"
     ]
 }
diff --git a/src/renderer/src/stories/pages/guided-mode/data/GuidedSourceData.js b/src/renderer/src/stories/pages/guided-mode/data/GuidedSourceData.js
@@ -104,14 +104,11 @@ export class GuidedSourceDataPage extends ManagedPage {
                     if (isStorybook) return;
 
                     if (result.message) {
-                        const [
-                            type,
-                            text = `<small><pre>${result.traceback
-                                .trim()
-                                .split("\n")
-                                .slice(-2)[0]
-                                .trim()}</pre></small>`,
-                        ] = result.message.split(":");
+                        const [type, ...splitText] = result.message.split(":");
+                        const text = splitText.length
+                            ? splitText.join(":").replaceAll("<", "&lt").replaceAll(">", "&gt")
+                            : `<small><pre>${result.traceback.trim().split("\n").slice(-2)[0].trim()}</pre></small>`;
+
                         const message = `<h4 style="margin: 0;">Request Failed</h4><small>${type}</small><p>${text}</p>`;
                         this.notify(message, "error");
                         throw result;