Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode Global Settings File #389

Merged
merged 9 commits into from
Sep 27, 2023
Merged

Encode Global Settings File #389

merged 9 commits into from
Sep 27, 2023

Conversation

garrettmflynn
Copy link
Member

This PR encrypts / decrypts strings in the global settings file.

fix #369

@CodyCBakerPhD
Copy link
Collaborator

The values of the API keys in the config.json text file appear the same as on main for me 🤔

I even deleted the file and saved a fresh one through the app

@garrettmflynn
Copy link
Member Author

Whoops! Was just logging the encoded values for testing, never actually saved them...

@CodyCBakerPhD
Copy link
Collaborator

One small conflict now

@garrettmflynn
Copy link
Member Author

Should be good to go!

@CodyCBakerPhD
Copy link
Collaborator

@garrettmflynn The new config file contents look good, but I can't navigate away from the settings page in the app after resetting the values

The popup

image

blocks me even if I keep hitting 'save and continue'

@garrettmflynn
Copy link
Member Author

Good catch. Fixed

@CodyCBakerPhD
Copy link
Collaborator

OK looks good now 👍

@CodyCBakerPhD CodyCBakerPhD merged commit 8071b78 into main Sep 27, 2023
7 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the encode-global-variables branch September 27, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discussion] Encryption of DANDI API keys?
2 participants