Flask-side refactors #791
Flask-side refactors #791
Conversation
| # 'nwbfile_registry' is a global list that keeps track of all NWB files that have been registered with the server | ||
| nwbfile_registry = [] |
There was a problem hiding this comment.
Actually, I do remember why this is a dict (faster lookup via hash map) so I'll change that back after we discuss if/how it's used
| description="Handle adding and fetching NWB files from the global file registry.", | ||
| responses=server_error_responses(codes=[200, 400, 404, 500]), | ||
| ) | ||
| def handle_file_request(file_path: str) -> Union[str, Response, None]: |
There was a problem hiding this comment.
@garrettmflynn Perhaps you can help clarify this endpoint
From https://github.com/search?q=repo%3ANeurodataWithoutBorders%2Fnwb-guide+%2Ffiles&type=code it seems it is only used in one place (the preview page for serving things to Neurosift) and only used as a POST and does not re-use the registry in that way (only purpose seem to be to get and return the base_url of the path)
Is there anywhere that uses the GET, or the other endpoint (https://github.com/NeurodataWithoutBorders/nwb-guide/pull/791/files#diff-d8bafe4fe7c605b4e3a4a4f41367e387da934fae16aa61026e33413861366228R89) that refers to the global registry?
There was a problem hiding this comment.
Neurosift implicitly uses the GET endpoint after setting the url parameter.
The idea is to only allow access to files the GUIDE knows the absolute path to.
…utborders/nwb-guide into document_payloads
for more information, see https://pre-commit.ci
Enhancing the Swagger with more docstrings, flatter code, more centralized error messages, and probably cleaner submodule localization