Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors for Coverage Scoping #857

Merged
merged 15 commits into from
Jun 14, 2024
Merged

Refactors for Coverage Scoping #857

merged 15 commits into from
Jun 14, 2024

Conversation

garrettmflynn
Copy link
Member

@garrettmflynn garrettmflynn commented Jun 12, 2024

This PR gets coverage near 50% by adding additional unit tests. Some utilities have also been reorganized for better scoping.

Wanted to open this early so that the process is transparent.

@garrettmflynn garrettmflynn self-assigned this Jun 12, 2024
@garrettmflynn garrettmflynn changed the title JavaScript Coverage ~50% Refactors for Coverage Scoping Jun 12, 2024
@CodyCBakerPhD CodyCBakerPhD linked an issue Jun 12, 2024 that may be closed by this pull request
@garrettmflynn
Copy link
Member Author

Alright as long as the tests pass, this should be good to go.

Just to emphasize what has been done, here's a representation of the folder hierarchies within the coverage report:

All files
└── electron
    └── frontend
        └── core
            └── components
                └── table
                    └── cells
                        └── renderers
            └── progress
            └── validation
        └── utils
└── schemas

@garrettmflynn
Copy link
Member Author

@CodyCBakerPhD Sorry about that. Looks like only Linux failing now.

@garrettmflynn garrettmflynn marked this pull request as ready for review June 13, 2024 22:26
@CodyCBakerPhD CodyCBakerPhD enabled auto-merge June 14, 2024 01:58
@CodyCBakerPhD CodyCBakerPhD merged commit f56ac2f into main Jun 14, 2024
20 of 21 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the fix-coverage branch June 14, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MVP] Increase tests of MVP-related functionality
2 participants