-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add end-to-end extension example for extending LabMetaData #59
Conversation
@bendichter @rly I've made the changes we discussed. This PR is ready for review. |
|
||
git add spec/*.yaml | ||
git commit -m "Added extension schema files" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not add all the files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean do git add spec/
instead? Since the spec folder should only contain YAML files, both approaches should typically be identical. Either way is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I mean add the Python files, i.e. git add .
instead. This could be a separate step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that's fine too. The main reason for this was because those are the files that I modified in this step, so I just tried to be specific about that, but either way is fine.
docs/source/extensions_tutorial/extension_examples/labmetadata_extension.rst
Show resolved
Hide resolved
I moved the bullet point about |
Fix #60
Create an end-to-end example for how to create extension for adding lab-specific metadata to an NWBFile by extending the
LabMetaData
typeTODO: