Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hdmf common schema 1.5.0 and update release notes #473

Merged
merged 5 commits into from
Apr 23, 2021
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented Apr 22, 2021

Use hdmf common schema 1.5.0 and update release notes (tentative release April 23)

@rly
Copy link
Contributor Author

rly commented Apr 22, 2021

We had discussed removing the hdmf-common-schema git submodule from this repo because this version of hdmf-common is not loaded by PyNWB, but rather, the version cached in the local copy of HDMF is loaded. So having this copy of hdmf-common may be confusing. However until the schema language supports a 'version' key: hdmf-dev/hdmf-schema-language#11 , I think it is useful to include in the nwb schema a copy of a known compatible version of HDMF common.

@rly rly requested review from oruebel and ajtritt April 22, 2021 23:20
oruebel
oruebel previously approved these changes Apr 22, 2021
@rly rly requested a review from oruebel April 23, 2021 00:04
oruebel
oruebel previously approved these changes Apr 23, 2021
@rly rly merged commit 34212f3 into dev Apr 23, 2021
@rly rly deleted the hdmf_common_1.5.0 branch April 23, 2021 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants