Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating poisson and log-normal simulations #63

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

Saladino93
Copy link

I have written a first version for the log-normal and poisson simulations. These were useful for foregrounds and non-Gaussianity test I have made for the projects.

I imagine they would be useful in general.

Also, implemented a first version to make it easy to combine sims at a more higher level (e.g. if I have a class with CMB+noise, and a class with foregrounds only, "summing" the classes allows me to get a tmap with CMB+noise+foregrounds).

Saladino93 and others added 7 commits June 21, 2023 10:09
…owing a full covariance with a simple basic approximation
…, as well as a sims_general module to try something enw
…tions in poisson map, simple match filter to create a mask for point sources
Copy link
Member

@Sebastian-Belkner Sebastian-Belkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
As this is a new feature, can we have a minimal working example of how to use the new sims?
A couple of lines showing how you generate lognormal sims would help a lot.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this called "extra"? Is this a reference to extragalactic?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably will take out this, but yes, it was for that purpose.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! Thanks for looking into this. Will put an example.

@Sebastian-Belkner
Copy link
Member

@Saladino93 what's the status here? looks like we still have merge conflicts for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code development enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants