Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow using templating with terminationGracePeriodSeconds #325

Merged
merged 5 commits into from
Aug 6, 2024

Conversation

stlava
Copy link
Member

@stlava stlava commented Aug 6, 2024

Adds template parsing on terminationGracePeriodSeconds in order to allow referencing or computing the termination value.

@stlava stlava requested a review from a team as a code owner August 6, 2024 17:39
@@ -3,8 +3,6 @@ apiVersion: v1
kind: Pod
metadata:
name: "{{ include "nd-common.fullname" . }}-test-connection"
labels:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how this ever worked helm/helm#8058

@stlava stlava merged commit 4fa52fe into main Aug 6, 2024
2 checks passed
@stlava stlava deleted the template-term branch August 6, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant