Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore): Allow passing kafka and zookeeper resource limits via values file #340

Closed
wants to merge 5 commits into from
Closed

(chore): Allow passing kafka and zookeeper resource limits via values file #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
04aa29e
(chore): Allow passing kafka and zookeeper resource limits via values…
philkjacobs-nextdoor Sep 27, 2024
7f08657
fix comment
philkjacobs-nextdoor Sep 27, 2024
59e1056
helm docs
philkjacobs-nextdoor Sep 27, 2024
52ad7bf
set to empty map by default
philkjacobs-nextdoor Sep 28, 2024
e3f70a4
helm docs
philkjacobs-nextdoor Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/local-kafka/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: local-kafka
description: Local Development spinup of Strimzi-managed Kafka
type: application
version: 0.42.1
version: 0.42.2
appVersion: latest
maintainers:
- name: diranged
Expand Down
4 changes: 3 additions & 1 deletion charts/local-kafka/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Local Development spinup of Strimzi-managed Kafka

![Version: 0.42.1](https://img.shields.io/badge/Version-0.42.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: latest](https://img.shields.io/badge/AppVersion-latest-informational?style=flat-square)
![Version: 0.42.2](https://img.shields.io/badge/Version-0.42.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: latest](https://img.shields.io/badge/AppVersion-latest-informational?style=flat-square)

[strimzi_op]: https://github.com/strimzi/strimzi-kafka-operator

Expand Down Expand Up @@ -45,6 +45,7 @@ project's development namespace.
| kafka.interBrokerProtocolVersion | `str` | `nil` | Optional value for the inter.broker.protocol.version property (eg. `2.8`) |
| kafka.logMessageFormatVersion | `str` | `nil` | Optional value for the log.message.format.version property (eg, `2.7`) |
| kafka.priorityClassName | `str` | `nil` | Optional value for the kafka cluster pod priority class name |
| kafka.resources | string | `nil` | Optional resource requirements for the Kafka cluster |
| listeners | list | `[{"configuration":{"brokers":[{"advertisedHost":"127.0.0.1","broker":0,"nodePort":32000}]},"name":"external","port":9094,"tls":false,"type":"nodeport"}]` | Additional configurable listeners for connecting to brokers. |
| namespaceOverride | string | `nil` | Optionally force the namespace that the resources in this stack are launched in. Without this, the default namespace that the Helm chart is being put into is used. It is recommended to keep this empty. |
| strimzi-kafka-operator.enabled | bool | `true` | Set to `false` to intentionally disable installation of the Operator. This is useful if you are running this stack in a local dev environment where you might have multiple Kafka environments, and are already running the Strimzi operator. |
Expand All @@ -58,6 +59,7 @@ project's development namespace.
| strimzi-kafka-operator.resources | object | `{"limits":{"memory":"1Gi"},"requests":{"cpu":"250m","memory":"512Mi"}}` | Reconfigure the default resource requirements here so that the "requests" are as low as possible for memory (so we're not allocating any more memory than we absolutely must). |
| strimzi-kafka-operator.watchAnyNamespace | bool | `true` | Because you can only install one Strimzi Operator helm chart in a cluster, we might as well set this to True. This allows the chart to be re-used (with `strimzi-kafka-operator.enabled: false`) by other local development projects. |
| userName | string | `"user"` | Set the name of the KafkaUser that is created for local development |
| zookeeper.resources | string | `nil` | Optional resource requirements for the Zookeeper cluster |

----------------------------------------------
Autogenerated from chart metadata using [helm-docs v1.11.0](https://github.com/norwoodj/helm-docs/releases/v1.11.0)
8 changes: 8 additions & 0 deletions charts/local-kafka/templates/kafka.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,20 @@ spec:
type: persistent-claim
size: 500Mi
deleteClaim: false
{{ with .Values.kafka.resources }}
resources:
{{ toYaml . | nindent 6 }}
{{ end }}
zookeeper:
replicas: 1
storage:
type: persistent-claim
size: 500Mi
deleteClaim: false
{{ with .Values.zookeeper.resources }}
resources:
{{ toYaml . | nindent 6 }}
{{ end }}
entityOperator:
topicOperator: {}
userOperator: {}
7 changes: 7 additions & 0 deletions charts/local-kafka/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@ kafka:
# -- (`str`) Optional value for the kafka cluster pod priority class name
priorityClassName:

# -- Optional resource requirements for the Kafka cluster
resources:

zookeeper:
# -- Optional resource requirements for the Zookeeper cluster
resources:

# -- Additional configurable listeners for connecting to brokers.
listeners:
- name: external
Expand Down
Loading