fix(nd-common): support istio-proxy native sidecar (initContainer) preStop override #361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Context
Kubernetes native sidecar containers run as
InitContainers
Istio allows us to run the proxy as a native sidecar.
What This Change Does
Allows preStop commands to be set on initContainers as well.
But Why Is This Change Needed?
Ideally, the default /drain on native sidecars should suffice.
However, an open bug (istio/istio#51855) is forcing us to potentially bring our default preStop commands on the native sidecars as well.
Diffs
Diff between default values and setting
istio.nativeSidecarsEnabled: true
When to use: This is the proposed ideal setting when we want a workaround to istio/istio#51855
Diff between default values and setting
istio.nativeSidecarsEnabled: true
andpreStopDefaultEnabled: false
When to use: This is the proposed ideal setting when istio/istio#51855 is fixed and we want to default to upstream/Istio's drain mechanism... i.e., no override