fix(ci): Fix flaky tests related to stubber out of order expectations #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaikaN57
commented
Feb 12, 2025
| self.iam_stubber.add_client_error("list_user_policies", "400", "NoSuchEntity") | ||
| self.iam_stubber.activate() | ||
| ret = yield self.actor._get_entity_policies("test") | ||
| self.assertEqual(ret, {}) | ||
|
|
||
| @testing.gen_test | ||
| def test_get_entities_other_500(self): | ||
| self.iam_stubber.add_client_error("list_user_policies", "400", "NoSuchEntity") |
LaikaN57
commented
Feb 12, 2025
| @@ -74,26 +74,23 @@ def test_get_entity_policies_500(self): | |||
|
|
|||
| @testing.gen_test | |||
| def test_get_entity_policies_400(self): | |||
| # Next, what if the entity doesn't exist at all? | |||
| self.iam_stubber = Stubber(self.actor.iam_conn) | |||
There was a problem hiding this comment.
Removed to standardize on common Stubber.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boto3 Stubber expects calls to come in order. However, our code (or the underlying libraries) can do calls in a random order. This PR helps eliviate the in order expectations.