Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] refactor build-logic, init network module #21

Merged

Conversation

murjune
Copy link
Member

@murjune murjune commented Jan 28, 2024

관련 이슈

작업한 내용

  • build-logic 모듈을 처음 짤 때 의존성이 너무 스파게티같이 엮여 있어서 리팩토링을 했습니다!
  • core:network 모듈 생성
  • hilt : kapt -> ksp로 마이그레이션

PR 포인트

  • feature

image

  • designSystem.

image.

@murjune murjune requested a review from ham2174 January 28, 2024 12:08
@murjune murjune self-assigned this Jan 28, 2024
@murjune murjune changed the title Feature/refactoring build logic and init network module [feat] refactor build-logic, init network module Jan 28, 2024
Copy link
Member Author

@murjune murjune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ham2174 참고 부탁드려용~

Comment on lines +7 to +19
/**
* 순수 JVM 라이브러리를 위한 플러그인 ex) domain
* */
class JvmLibraryPlugin : Plugin<Project> {
override fun apply(target: Project) {
with(target) {
with(pluginManager) {
apply("org.jetbrains.kotlin.jvm")
}
configureKotlinJvm()
}
}
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain 만들 때 얘를 사용하심 됩니당

import org.gradle.kotlin.dsl.dependencies
import org.gradle.kotlin.dsl.kotlin

class AndroidLibraryPlugin : Plugin<Project> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안드로이드 의존성이 있는 모듈있을 때 사용하심됩니다~

Copy link
Collaborator

@ham2174 ham2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

귯귯~! 바로 머지 해도 될것 같네용

@murjune
Copy link
Member Author

murjune commented Jan 28, 2024

땡큐입니당~

@murjune murjune merged commit a5adb0f into develop Jan 28, 2024
1 check passed
@murjune murjune deleted the feature/refactoring-build-logic-and-init-network-module branch January 28, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] Build-logic 리팩토링, init network-module
2 participants