[feat] domain module 세팅, matching profile entity 설정 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ham2174
approved these changes
Feb 4, 2024
| val lines: List<SubwayLine> = emptyList(), | ||
| ) | ||
|
|
||
| enum class SubwayLine { |
There was a problem hiding this comment.
지하철 라인이 피그마에서 23개입니다!
- 미포함 라인 : 인천1호선, 인천2호선, 의정부, 우이신설, 김포골드, 신림, 경강, 서해
There was a problem hiding this comment.
이 부분 서버랑 네이밍 맞추면 좋을 거 같아서 일단 보류해 둘게유~
서버 enum 긁어온건디 지하철 api 아직 구현 전인거 같넹
core/domain/src/main/java/com/moya/funch/entity/SubwayStation.kt
Outdated
Show resolved
Hide resolved
core/domain/src/main/java/com/moya/funch/entity/profile/Profile.kt
Outdated
Show resolved
Hide resolved
core/domain/src/main/java/com/moya/funch/repository/MatchingRepository.kt
Show resolved
Hide resolved
murjune
force-pushed
the
feature/matching-domain
branch
from
9c96b6e
to
4af29b5
Compare
murjune
force-pushed
the
feature/matching-domain
branch
from
4af29b5
to
418eac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업한 내용
PR 포인트
Job, Club의 경우에만 companion object로
of팩토리 함수를 만들었습니다. 나머지 Blood, Mbti 같은 경우는 valueOf로 충분히 대체 가능하기 떄문이에요! 따라서, Job과 Club만 testCode를 작성했습니다.추가적으로 보통 test코드는
given/when/then기법을 사용하지만, 1~2줄 정도로 테스트가 가능한 경우에는 생략해도 괜찮다고 생각해서 아래와 같이 작성했습니다 ~ 😸추가적으로, 보통 usecase도 테스트 코드로 작성하지만
of라는 네이밍을 갖는 함수가 보통 팩토리 함수로 많이 사용되기 때문에 �예외케이스만 작성하였습니다@Nexters/funch-aos 추가적으로 제가 지금 스키장이라 화요일 저녁까지는 답을 잘 못할 수도 있습니다..
🚀Next Feature