Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/home data domain logic #54

Merged
merged 7 commits into from
Feb 10, 2024
Merged

Conversation

murjune
Copy link
Member

@murjune murjune commented Feb 10, 2024

관련 이슈

작업한 내용

이 부분 서버 연동하기 위한 UseCase를 만들었습니다!
(일단은 서버 api가 따로 없기 때문에 fetchMemberByID API로 이 부분을 불러왔습니다.)

  • LoadViewCountUseCase 구현
    - [x] 관련 MemberRepository, RemoteMemberDataSource 수정

🚀Next Feature

@murjune murjune added the june🙇‍♂️ New feature or request label Feb 10, 2024
@murjune murjune requested a review from a team February 10, 2024 16:42
@murjune murjune self-assigned this Feb 10, 2024
@murjune murjune requested a review from ham2174 February 10, 2024 16:42
Copy link
Collaborator

@ham2174 ham2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 하나 남깁니다~!

@@ -7,5 +7,5 @@ interface MemberRepository {

suspend fun createUserProfile(profile: Profile): Result<Profile>

suspend fun fetchMemberProfile(id: String): Result<Profile>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id로 찾는건 멤버 프로필 가져오는건 따로 구현할 예정인건가??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

으악... UserRemoteSource에서 작업했어야하는데 MemberRemoteSource에서 작업했네유...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fun fetchMemberProfile(id) 도 다시 살려두고 다시 수정하겠습니다😅

@murjune
Copy link
Member Author

murjune commented Feb 10, 2024

@ham2174 수정완!😸

Copy link
Collaborator

@ham2174 ham2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인!!

@murjune murjune merged commit dd879d8 into develop Feb 10, 2024
1 check passed
@murjune murjune deleted the feature/Home-Data-Domain-logic branch February 10, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
june🙇‍♂️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] LoadViewCountUseCase 와 관련 data 모듈 구현
2 participants