[Feature] 프로필 생성 기능 제작 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murjune
approved these changes
Feb 13, 2024
Comment on lines
+83
to
+94
| LaunchedEffect(Unit) { | ||
| viewModel.event.collect { event -> | ||
| when (event) { | ||
| is CreateProfileEvent.NavigateToHome -> { | ||
| onNavigateToHome() | ||
| } | ||
| is CreateProfileEvent.ShowError -> { | ||
| // @Gun Hyung TODO : 에러 메시지 호출 | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
이렇게 하게될 경우 사용자가 Home 버튼을 누르고 나갈 때도 Event 를 collect()하게 될 것 같아!
따라서, .collectAsStateWithLifecycle() 를 사용하는게 좋을 거 같습니당
There was a problem hiding this comment.
사용자가 앱을 중간에 나가도 Event를 수집하는 형태가 괜찮다고 판단해서 .collect()를 사용했어!
만일 서버 요청 상태가 오래 지속되는 작업이라면 sharedFlow를 사용하지않으면서 .collectAsStateWithLifecycle()를 사용했을것 같아.
거기다 현재 Event를 SharedFlow로 정의해놓아서 .collectAsStateWithLifecycle()를 사용하게되면 현재 초기값을 넣어주어야 하는것으로 알고있는데 그러면 Event를 정의할 때 'None' 상태를 하나 추가해두어야 하는걸까?
There was a problem hiding this comment.
사용자가 앱을 중간에 나가도 Event를 수집하는 형태가 괜찮다고 판단해서 .collect()를 사용했어!
만일 서버 요청 상태가 오래 지속되는 작업이라면 sharedFlow를 사용하지않으면서 .collectAsStateWithLifecycle()를 사용했을것 같아.
이런 이유라면 지금 로직 찬성입니다~ (뭔가 이런 의도일거라 생각해서 머지해도 찬성함 ㅋㅋㅋ😁)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업한 내용
Screen_recording_20240214_004615.mp4
PR 포인트
🚀Next Feature