Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 내 프로필 기능 구현 #68

Merged
merged 9 commits into from
Feb 17, 2024
Merged

Conversation

ham2174
Copy link
Collaborator

@ham2174 ham2174 commented Feb 15, 2024

관련 이슈

작업한 내용

  • 내 프로필 기능 ViewModel 연결

PR 포인트

  • LocalUserDataSourceImpl에서 dataStore.clear() 해주는 주석을 제거했습니다.
    image

  • 데이터스토어에서 값을 불러오지 못할시, 서버를 통해 데이터를 가져오기 때문에 UI State를 Error, Loading, Success로 정의하였습니다. (Loading 상태로 초기화가 되어있으며 현재는 로딩 상태일때 어떠한 화면도 표시되지 않습니다.)

🚀Next Feature

@ham2174 ham2174 added the ham😸 Good for newcomers label Feb 15, 2024
@ham2174 ham2174 requested a review from murjune February 15, 2024 08:39
@ham2174 ham2174 self-assigned this Feb 15, 2024
Copy link
Member

@murjune murjune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~!! 👍👍👍
거의 그럴일은 없겠지만?(우린 로컬에서 불러오니깐)
만약 로딩 상태가 되면 빈 White Screen이 보여질 것 같긴합니다.
따라서, 로딩 상태나 에러 상태일 때 ToolBar나 Card 빈 형태라도 보여주도록 하는게 어떨까요?!

@ham2174
Copy link
Collaborator Author

ham2174 commented Feb 15, 2024

@murjune 로딩 상태와 에러 상태일 때 빈 카드가 나오게 추가할게용~~

@ham2174 ham2174 merged commit 3467022 into develop Feb 17, 2024
1 check passed
@ham2174 ham2174 deleted the feature/feat-my-profile branch February 17, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ham😸 Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 내 프로필 기능
2 participants