Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] onboarding lottie -> Icon 으로 바꾸기, dummyId -> dataStore.id로 바꾸기 #69

Merged
merged 2 commits into from
Feb 15, 2024
Merged

[Feature] onboarding lottie -> Icon 으로 바꾸기, dummyId -> dataStore.id로 바꾸기 #69

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73feb58
[chore] DUMMY_ID -> dataStore.userId
murjune Feb 15, 2024
864217a
[feat] onBoarding Lottie -> ImageIcon
murjune Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions core/data/src/main/java/com/moya/funch/datasource/remote/RemoteMatchDataSourceImpl.kt
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

커밋하려는 순간에 해당 커밋 푸쉬되서 충돌날뻔 ㅋㅋㅋㅋ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나이스 타이밍~~~

Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,10 @@ class RemoteMatchDataSourceImpl @Inject constructor(
return runCatching {
matchingService.matchProfile(
MatchingRequest(
userId = DUMMY_ID,
userId = dataStore.userId,
targetCode = targetCode
)
)
// @murjune TODO change - dataStore.userId
}.mapCatching { it.data }
}

companion object {
private const val DUMMY_ID = "65c9d597ffc89209ea09ce24"
}
}