init design system #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ham2174
reviewed
Jan 22, 2024
core/designsystem/build.gradle.kts
Outdated
| @@ -0,0 +1,10 @@ | |||
| @Suppress("DSL_SCOPE_VIOLATION") // TODO: Remove once KTIJ-19369 is fixed | |||
| plugins { | |||
| alias(libs.plugins.funch.feature) | |||
There was a problem hiding this comment.
alias(libs.plugins.funch.feature) 요거 플러그인은 피처 모듈에서만 사용되는거 아닌가요..?
build-logic에서 CommonConfigs.kt 파일에서 KotlinSerializationPlugin, AndroidHiltPlugin를 사용하고 있는데 디자인 시스템에서 모듈에서 사용이 되는지 궁금합니다!!
plugins {
id("com.android.library")
alias(libs.plugins.funch.kotlin)
alias(libs.plugins.funch.compose)
}
요렇게 작성하는건 어떤가용??
core/designsystem/build.gradle.kts
Outdated
| @@ -0,0 +1,10 @@ | |||
| @Suppress("DSL_SCOPE_VIOLATION") // TODO: Remove once KTIJ-19369 is fixed | |||
There was a problem hiding this comment.
@Suppress("DSL_SCOPE_VIOLATION") 요구문은 찾아보니까 그래들 8.2이상이면 필요 없다고 합니다~! 링크
ham2174
approved these changes
Jan 22, 2024
murjune
force-pushed
the
feature/init-design-system
branch
from
a0644ec
to
392e6b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업한 내용
PR 포인트