Fix outdated instructions in from-gatsby.md #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original instructions when converting from gatsby to next had users wrap the inner HTML inside the "Link" in an "a" tag, this is incorrect as of version 13+ and throws an error. I just refactored my project as per the instructions and am now going through to revert it. Tweaked wording and example for the correct and up dated process.
jaredar1232
requested review from
Shinyaigeek,
hoosan,
hiro08gh,
thesugar,
yokinist and
5t111111
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original instructions when converting from gatsby to next had users wrap the inner HTML inside the "Link" in an "a" tag, this is incorrect as of version 13+ and throws an error. I just refactored my project as per the instructions and am now going through to revert it. Tweaked wording and example for the correct and updated process.
Also, if you're hiring I'm currently looking for a job :D
Cheers