Merge branch 'steam-login' of https://github.com/Nexus-Mods/NexusMods…

….App into steam-login

src/Abstractions/NexusMods.Abstractions.Hashes/HashJsonConverter.cs

@@ -10,19 +10,31 @@ namespace NexusMods.Abstractions.Hashes;
 /// </summary>
 public class HashJsonConverter : JsonConverter<Hash>
 {
+    /// <inheritdoc/>
     public override Hash Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
     {
-        Span<byte> chars = stackalloc byte[8];
-        Convert.FromHexString(reader.GetString()!, chars, out _, out _);
-        return Hash.FromULong(MemoryMarshal.Read<ulong>(chars));
+        var input = reader.GetString();
+        if (input is null) throw new JsonException();
+
+        Span<byte> bytes = stackalloc byte[sizeof(ulong)];
+
+        var status = Convert.FromHexString(input, bytes, out _, out _);
+        Debug.Assert(status == OperationStatus.Done);
+
+        var value = MemoryMarshal.Read<ulong>(bytes);
+        return Hash.FromULong(value);
     }
 
+    /// <inheritdoc/>
     public override void Write(Utf8JsonWriter writer, Hash value, JsonSerializerOptions options)
     {
-        Span<char> span = stackalloc char[16];
-        Span<byte> bytes = stackalloc byte[8];
+        Span<char> span = stackalloc char[sizeof(ulong) * 2];
+        Span<byte> bytes = stackalloc byte[sizeof(ulong)];
         MemoryMarshal.Write(bytes, value.Value);
-        Convert.TryToHexString(bytes, span, out _);
+
+        var success = Convert.TryToHexString(bytes, span, out _);
+        Debug.Assert(success);
+
         writer.WriteStringValue(span);
     }
 }