Merge pull request #1692 from Nexus-Mods/disable-ui-test

Disable View and Overlay tests from CI to prevent stalling
Nexus-Mods · Jun 26, 2024 · cdfcc2d · cdfcc2d
2 parents 7550468 + 0761e3d
commit cdfcc2d
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 2 deletions.
diff --git a/tests/NexusMods.UI.Tests/Controls/LaunchButtonViewTests.cs b/tests/NexusMods.UI.Tests/Controls/LaunchButtonViewTests.cs
@@ -27,6 +27,7 @@ protected override async Task PostInitializeSetup()
     }
 
     [Fact]
+    [Trait("FlakeyTest", "True")]
     public async Task ClickingTheButtonFiresTheCommand()
     {
         var source = new TaskCompletionSource<bool>();
@@ -49,6 +50,7 @@ await EventuallyOnUi(() =>
     }
 
     [Fact]
+    [Trait("FlakeyTest", "True")]
     public async Task LabelTextAffectsButtonAndProgressText()
     {
         var text = Random.Shared.Next() + " Text";
@@ -61,7 +63,6 @@ await EventuallyOnUi(() =>
     }
 
     [Fact]
-    // Seems to very seldom stall CI, could be made to fail if run un repeat for enough times locally
     [Trait("FlakeyTest", "True")]
     public async Task ProgressAffectsProgressBar()
     {
@@ -83,6 +84,7 @@ await EventuallyOnUi(() =>
     }
 
     [Fact]
+    [Trait("FlakeyTest", "True")]
     public async Task InProgressTaskAffectsControlVisibility()
     {
         var tcs = new TaskCompletionSource();
@@ -110,6 +112,7 @@ await EventuallyOnUi(() =>
     }
 
     [Fact]
+    [Trait("FlakeyTest", "True")]
     public async Task DisablingTheButtonShowsATheProgressBar()
     {
 
@@ -125,6 +128,7 @@ await EventuallyOnUi(() =>
     }
 
     [Fact]
+    [Trait("FlakeyTest", "True")]
     public async Task EnabledCommandShouldShowEnabledButton()
     {
         var subject = new Subject<bool>();

diff --git a/tests/NexusMods.UI.Tests/Controls/Spine/DownloadButtonViewTests.cs b/tests/NexusMods.UI.Tests/Controls/Spine/DownloadButtonViewTests.cs
@@ -12,6 +12,7 @@ public class DownloadButtonViewTests : AViewTest<SpineDownloadButtonView, SpineD
     public DownloadButtonViewTests(IServiceProvider provider) : base(provider) { }
 
     [Fact]
+    [Trait("FlakeyTest", "True")]
     public async Task SettingButtonToActiveAppliesProperClass()
     {
         var button = await Host.GetViewControl<Button>("ParentButton");
@@ -30,6 +31,8 @@ await EventuallyOnUi(() =>
     }
 
     [Fact]
+    [Trait("FlakeyTest", "True")]
+
     public async Task SettingProgressSetsClassesAndValues()
     {
         var button = await Host.GetViewControl<Button>("ParentButton");
@@ -70,6 +73,8 @@ await OnUi(() =>
     }
 
     [Fact]
+    [Trait("FlakeyTest", "True")]
+
     public async Task SettingUnitAndNumberChangesTextValues()
     {
         var numberBlock = await Host.GetViewControl<TextBlock>("NumberTextBlock");
@@ -110,6 +115,8 @@ await EventuallyOnUi(() =>
     }
 
     [Fact]
+    [Trait("FlakeyTest", "True")]
+
     public async Task ClickingTheButtonTriggersTheCommand()
     {
         await ButtonShouldFireReactiveCommand(vm => vm.Click, "ParentButton");

diff --git a/tests/NexusMods.UI.Tests/Overlays/NexusLoginOverlayTests.cs b/tests/NexusMods.UI.Tests/Overlays/NexusLoginOverlayTests.cs
@@ -14,6 +14,7 @@ public class NexusLoginOverlayTests
 {
 
     [Fact]
+    [Trait("FlakeyTest", "True")]
     public async Task LoginTasksCreateOverlays()
     {
         var overlayController = new OverlayController();

diff --git a/tests/NexusMods.UI.Tests/Overlays/OverlayViewModelTests.cs b/tests/NexusMods.UI.Tests/Overlays/OverlayViewModelTests.cs
@@ -8,6 +8,8 @@ namespace NexusMods.UI.Tests.Overlays;
 public class OverlayViewModelTests
 {
     [Fact]
+    [Trait("FlakeyTest", "True")]
+
     public void SetOverlayContent_CanGetLastOverlayViewModel()
     {
         // Arrange
@@ -22,6 +24,8 @@ public void SetOverlayContent_CanGetLastOverlayViewModel()
     }
 
     [Fact]
+    [Trait("FlakeyTest", "True")]
+
     public void SetOverlayContent_WithTwoOverlays_CanGetLastOverlayViewModel()
     {
         // Arrange
@@ -50,6 +54,8 @@ public void SetOverlayContent_WithTwoOverlays_CanGetLastOverlayViewModel()
     }
 
     [Fact]
+    [Trait("FlakeyTest", "True")]
+
     public void SetOverlayContent_WithThreeOverlays_CanGetLastOverlayViewModel()
     {
         // Arrange
@@ -86,7 +92,6 @@ public void SetOverlayContent_WithThreeOverlays_CanGetLastOverlayViewModel()
     }
 
     [Fact]
-    // intermittent failures on CI but not locally
     [Trait("FlakeyTest", "True")]
     public async Task SetOverlayViewModel_WhenActiveIsFalse_TaskIsCompleted()
     {

diff --git a/tests/NexusMods.UI.Tests/Overlays/UpdaterViewTests.cs b/tests/NexusMods.UI.Tests/Overlays/UpdaterViewTests.cs
@@ -10,6 +10,7 @@ public class UpdaterViewTests : AViewTest<UpdaterView, UpdaterDesignViewModel, I
     public UpdaterViewTests(IServiceProvider provider) : base(provider) { }
 
     [Fact]
+    [Trait("FlakeyTest", "True")]
     public async Task ClickingUpdateCallsTheCommand()
     {
         var controller = new OverlayController();
@@ -28,6 +29,7 @@ await EventuallyOnUi(() =>
     }
 
     [Fact]
+    [Trait("FlakeyTest", "True")]
     public async Task ShowChangelogIsWiredCorrectly()
     {
         var controller = new OverlayController();
@@ -43,6 +45,7 @@ await EventuallyOnUi(() =>
     }
 
     [Fact]
+    [Trait("FlakeyTest", "True")]
     public async Task ClickingLaterClosesTheOverlay()
     {
         var controller = new OverlayController();
-Original file line number
+Diff line change
@@ Expand Up / @@ -14,6 +14,7 @@ public class NexusLoginOverlayTests @@
     {
         [Fact]
+        [Trait("FlakeyTest", "True")]
         public async Task LoginTasksCreateOverlays()
         {
             var overlayController = new OverlayController();
@@ Expand Down @@