Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections: change "Prefer Exact" mod version selection logic #2329

Open
LukeNexusMods opened this issue Dec 2, 2024 · 1 comment
Open
Labels
Epic: Collections This is related to NexusMods Collections.

Comments

@LukeNexusMods
Copy link
Collaborator

LukeNexusMods commented Dec 2, 2024

Investigate the logic for the different collection file options and make sure we are doing the right thing for each one.

Currently we are downloading the exact version indicated in the collection manifest, even if that version was archived.
Vortex picks the most recent version in case the file was archived instead.

Some questions:
We could still be grabbing an archived mod depending on when we do the check.
When do we perform the check for which mod version to download?

  • Only once at collection fetch then never again?
  • At the moment of download of the mod?
  • Re-check every time and mark as outdated even if already downloaded?

If we want to check after the initial collection fetch, we need to store that information somewhere.

@Pickysaurus
Copy link
Contributor

@LukeNexusMods LukeNexusMods added this to the SDV Beta Release milestone Dec 2, 2024
@Al12rs Al12rs changed the title Prefer Exact Logic Collections: "Prefer Exact" mod version selection logic Dec 3, 2024
@Al12rs Al12rs added the Epic: Collections This is related to NexusMods Collections. label Dec 3, 2024
@Al12rs Al12rs changed the title Collections: "Prefer Exact" mod version selection logic Collections: change "Prefer Exact" mod version selection logic Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic: Collections This is related to NexusMods Collections.
Projects
Status: No status
Development

No branches or pull requests

3 participants