-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source generator read models #1626
Merged
Merged
Changes from all commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
1ff1526
Filestore and attributes mostly done
halgari 107ac8b
WIP, slowly porting over Loadouts
halgari fb7b613
Loadouts project compiles
halgari bcea443
Work on syncronizer code
halgari bf6739d
WIP
halgari 904ab0f
Update to new IndexSegment code from MnemonicDB
halgari 4a5eaeb
Merge branch 'main' into source-generator-read-models
halgari 7d5d62d
Abstraction tests pass
halgari 64a9113
WIP
halgari c8b08f5
Datamodel almost passes
halgari 0a9f757
Datamodel tests compile
halgari 063447a
Apply service tests pass
halgari c94227d
All datamodel tests (except one) pass. Waiting on Github actions to c…
halgari 4f7ef2e
Tons of code rework
halgari f4b3332
Nexus API compiles
halgari c899adf
Bannerlord compiles
halgari 1ba9c3e
SDV compiles
halgari 452c36b
Only the UI left
halgari 6fbd93d
32 errors left, but it's almost midnight
halgari ee992ba
Everything builds, ship it, I'm sure it'll be fine
halgari f929ce0
Downloader tests pass
halgari 5dc8cc2
Fix NexusWebApi tests
halgari cb4f21d
CLI tests pass
halgari f21c9ad
Bethesda tests pass
halgari 7b8921a
Cyberpunk tests pass, UI tests pass
halgari 3dc4b9e
Fix loadout deletion
halgari 92cdcef
Merge branch 'main' into source-generator-read-models
halgari c8e2d5d
Wow tests actually pass if run in smaller groups
halgari 1d92ce1
Fix a few bugs, delete end-to-end tests that we no longer want
halgari 7156c53
Fix several exceptions that popped up during testing
halgari abd1b3f
Fix a bunch of remaining exceptions with observables
halgari 48624d7
Can log in and out of the Nexus
halgari 8c58766
Merge branch 'main' into source-generator-read-models
halgari 08f372b
Merge main
halgari 5a28436
Update MnemonicDB to handle the new feedback from reviewing MnemonicDB
halgari fe7977a
Merge branch 'main' into source-generator-read-models
halgari d75fb58
Merge main
halgari 1b0a798
Handle feedback in Loadout.cs
halgari 774d536
Update src/Abstractions/NexusMods.Abstractions.Loadouts/Files/Metadat…
halgari 92e40ce
Update src/Abstractions/NexusMods.Abstractions.Loadouts/Files/File.cs
halgari 0696741
Update src/Abstractions/NexusMods.Abstractions.Loadouts.Synchronizers…
halgari 118dc82
Update src/Abstractions/NexusMods.Abstractions.Loadouts.Synchronizers…
halgari 78c2b31
Update src/Games/NexusMods.Games.StardewValley/Models/SMAPIModDatabas…
halgari b3b0051
PR feedback
halgari b6fba4d
More PR feedback
halgari 5959e03
Merge remote-tracking branch 'origin/source-generator-read-models' in…
halgari e2b743a
Update src/Games/NexusMods.Games.StardewValley/Models/SMAPIManifestMe…
halgari 89b7191
Update src/Abstractions/NexusMods.Abstractions.Loadouts.Synchronizers…
halgari eaa8ca3
Update src/NexusMods.App/TelemetryProvider.cs
halgari d08333e
Update src/NexusMods.DataModel/GameRegistry/Registry.cs
halgari 40280eb
Update src/NexusMods.DataModel/ArchiveInstaller.cs
halgari db56969
Update src/NexusMods.App/TelemetryProvider.cs
halgari 01145ab
Fix compiler issues, handle some of the feedback
halgari fe68569
Merge branch 'main' into source-generator-read-models
halgari c6e6e75
Merge main
halgari 9650a19
Handle some feedback
halgari 2517289
Handle more feedback
halgari f14b169
remove `!hasValue`
halgari 233d313
Handle final feedback
halgari 0106d50
All works except the file downloading handler
halgari f0c1ffd
Fix the broken downloader tests
halgari 466b054
Handle exceptions
halgari a0c6dfa
Revert changes to the download service so I can re-do the work so I b…
halgari 6fcd267
Compiles again
halgari 132e15c
Fix the `ObserveDatoms` bug in DownloadService.cs
halgari 68640ce
Fix a bug with ModEnabledViewModel.cs
halgari 6eff368
Fix the `Version` exception
halgari 9570c94
Fix completed items not showing up in the download window
halgari 1224072
WIP
halgari a916590
Reworked most of the download code
halgari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our download models are a complete mess, but I think
StreamBasedFileOriginMetadata
should includeDownloadAnalysis
.CC @Al12rs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we keep both yeah. It might be worth making a graph of these and decide what we actually need.
I'm not sure whether
DownloadAnalysis
still needs to be same entity as theDownloadTask
.Refactoring of download related entities could happen in a separate PRs if necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, we should do a pass on the analysis data this sprint